Add evolvesTo field as optional list of strings#16
Open
Hamatti wants to merge 1 commit into
Open
Conversation
I wasn't quite sure how to test this since the Gardevoir example used in tests is also missing evolution information in the API response, so I made the tests match what the real result would be.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed this field missing from the SDK so figured I'll add it.
I wasn't quite sure how to test this since the Gardevoir example used in tests is also missing evolution information in the API response, so I made the tests match what the real result would be.
If you'd like me to adjust the tests to also have a case where the evolvesTo is tested in a different way, happy to do that.